Added Links Folder and Refactored Codebase #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
IsabelParedes
requested changes
Oct 13, 2025
There was a problem hiding this comment.
Hi @Yahiewi, thank you!
It seems there is a bug when adding the robot to the scene. It causes the robot to disappear when trying to move the joints. This error shows up in the console
Uncaught TypeError: can't access property "traverse", this.scene.children[this._robotIndex] is undefinedCould you take another look? Thanks!
|
Resolves #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the links folder which has the following features:
-Coordinate frame visualization for each link
-An axis indicator that is synced with the orientation of the camera
-The option to change the opacity of each link
It also fixes the following bug:
-Links can now be correctly selected from the dropdown menu in the Joints Editor even if they are jointless
The codebase is also refactored to avoid cluttering the main classes.